-
Notifications
You must be signed in to change notification settings - Fork 1
Container policy restart #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-sprint-12
Are you sure you want to change the base?
Conversation
…ervability and added env sourcing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add restart policy for install_otel_collector_promtail_docker option.
For dockerised otel and promtail restart policy required. Already there is an attribute restart: unless-stopped in install_otel_collector_promtail_docker for both otel_collector and promtail. check if this works post reboot otherwise need to change as similar to create_device_agent_systemd_service.
For k3s option pod re-start automatically post reboot so it is not required for install_otel_collector_promtail
| show_menu() { | ||
| clear | ||
| echo "🎛️ WFM CLI Interactive Interface" | ||
| echo "🎛️ WFM CLI Interactive Interface(easy-CLI)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM CLI Interactive Interface(EasyCLI)"
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # ---------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this script there is only single file that is wfm.env, you can directly source <<wfm.env>> at start
|
|
||
| echo "✅ Observability systemd service created and enabled: $unit_file" | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here restart-policy not required as these all are pods they will automatically restart post vm reboot. Please revert this.
| echo " GITHUB_USER: ${GITHUB_USER:-'(not set)'}" | ||
| echo " GITHUB_TOKEN: ${GITHUB_TOKEN:-'(not set)'}" | ||
| return 1 | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong seems invalid code here, this we have already removed as it is taking only github_token
No description provided.