Skip to content

Conversation

@nitparihar
Copy link
Collaborator

No description provided.

Copy link
Contributor

@vireshnavalli vireshnavalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add restart policy for install_otel_collector_promtail_docker option.
For dockerised otel and promtail restart policy required. Already there is an attribute restart: unless-stopped in install_otel_collector_promtail_docker for both otel_collector and promtail. check if this works post reboot otherwise need to change as similar to create_device_agent_systemd_service.
For k3s option pod re-start automatically post reboot so it is not required for install_otel_collector_promtail

show_menu() {
clear
echo "🎛️ WFM CLI Interactive Interface"
echo "🎛️ WFM CLI Interactive Interface(easy-CLI)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM CLI Interactive Interface(EasyCLI)"

#!/bin/bash
set -e

# ----------------------------
Copy link
Contributor

@vireshnavalli vireshnavalli Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this script there is only single file that is wfm.env, you can directly source <<wfm.env>> at start


echo "✅ Observability systemd service created and enabled: $unit_file"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here restart-policy not required as these all are pods they will automatically restart post vm reboot. Please revert this.

echo " GITHUB_USER: ${GITHUB_USER:-'(not set)'}"
echo " GITHUB_TOKEN: ${GITHUB_TOKEN:-'(not set)'}"
return 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong seems invalid code here, this we have already removed as it is taking only github_token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants