fix(RenderableManager): scale bounding box from center instead of origin #328
+378
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you have a full log of the build error you're getting? I will test the PR on my own, but it would be really cool to see if we could get the example app working for you. It should be "as simple as":
|
Member
|
thanks for the PR btw! |
When a component unmounts and remounts while async resource loading is in progress, race conditions can occur: - useBuffer: stale Promise callbacks would call setBuffer() with outdated data after remount - useDisposableResource: calling release() on stale callbacks could release resources still in use by the new mount, causing "Pointer has already been manually released!" errors This commonly happens with: - Fast navigation (navigating away before loading completes) - Fast Refresh / Hot Reload during development - Conditional rendering with rapid state changes - React StrictMode (which double-mounts components in development) Changes: - Add token-based invalidation to useDisposableResource to ignore stale Promise callbacks from previous mounts - Don't call release() on stale callbacks - let GC handle cleanup via C++ shared_ptr preventing memory leaks - Add releaseOnUnmount option for explicit resource lifecycle control - Refactor useBuffer to use useDisposableResource (removes duplication)
Author
|
@hannojg Thanks! Looks like I forgot to run |
csouls
force-pushed
the
fix/scale-bounding-box-from-center
branch
from
4f36844 to
211c9ea
Compare
Add example screen to verify frustum culling behavior with scaleBoundingBox: - FrustumCulling.tsx: Interactive test with model and scale selection - hiphopgirl_offset.glb: Test model with mesh vertices baked at X=100 (world position X≈1 after Armature scale 0.01) Test behavior with offset model: - 1x, 2x scale: Model displays correctly - 5x+ scale: Model disappears due to bounding box center shift (demonstrates the bug that scaling from center fixes) Features: - Model type selection (Normal / Offset) - Scale factor selection (1x to 1000x) - Back button to return to settings
Previously, scaleBoundingBox multiplied min/max by scaleFactor, which shifted the bounding box center away from the model when the model was not at the origin. Now scales from center by: 1. Computing the bounding box center 2. Scaling the half-extent by scaleFactor 3. Reconstructing min/max from center ± scaledHalfExtent This preserves the bounding box position relative to the model, ensuring frustum culling works correctly for offset models.
csouls
force-pushed
the
fix/scale-bounding-box-from-center
branch
from
211c9ea to
28aab32
Compare
Author
|
Added a few more changes: FrustumCulling Example
StrictMode Race Condition Fix
Should I move the |
Member
|
hey, thanks for taking the time and the awesome fixes! Actually i will leave this up to you 😊 |
Author
|
The example app depends on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #326
scaleBoundingBoxto scale from the bounding box center instead of the originNote
@hannojg Thanks for the suggestion! I tried to add an example to the example app, but ran into a C++ build error on Android:
Looks like a pre-existing build config issue. Let me know if there's a workaround.