Fix: Unix time epoch bug in 'Saved' tab#23
Merged
mardous merged 1 commit intomardous:masterfrom Nov 1, 2025
Merged
Conversation
Single status save was't carrying timestamp, so it caused a unix time epoch in db [1 Jan 1970 as date for each singly saved status] also the saved statuses was not reloading after each save, so we had to manually refresh in-order to view the actual saved date
Owner
|
Hi, thanks for this. I'll check it out as soon as I have some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving a single status, its "Saved date" in the "Saved" tab would incorrectly show as "1 Jan 1970" [Unix time epoch issue].
This was because the save timestamp was not being recorded in the function.
Even after fixing the timestamp, the "Saved" tab would not update its UI until a manual pull-to-refresh was performed, due to a state management race condition.
StatusesRepositoryImpl.ktloadSavedStatuses()inside thesaveStatusfunction. This ensures that after a single save completes, a refresh of the "Saved" list is immediately triggered.onResume()override to theSavedStatusesFragment. This function is called every time the Saved tab becomes visible. By callingonRefresh()(which callsviewModel.loadSavedStatuses()) insideonResume(), we make sure the "Saved" tab always loads the newest data from the database the moment it appears, defeating the race condition.