Conversation
|
Wow! This looks so cool, thank you! I'll be merging it for sure. But before that, I want to be sure the review I just posted is correct. |
I'm sorry, but what review are you talking about? I hope this question is not as stupid as it sounds. 
|
This :-) |
|
am I missing something? There's nothing here... |
| this.shopHarvey.save(); | ||
|
|
||
| savegame.writeU8(Offsets.UNLOCK_NOOK, this.shopNookUnlock); | ||
| savegame.writeU8(Offsets.UNLOCK_NOOK+1, this.shopNookUnlock); |
There was a problem hiding this comment.
Is this intentional?
Are we sure the following byte to UNLOCK_NOOK is always a duplicate of the previous one?
I'd rather prefer to make this second byte so it only gets updated if user has changed the value in the select dropdown.
There was a problem hiding this comment.
As far as I was able to tell, this is used for expansions if you have spent enough bells, therefore it would totally make sense only to overwrite this if the user wants to change the building.
There was a problem hiding this comment.
Let me know when you've done the edit so I can merge it :-)
Sorry, looks like I missed clicking on the Start review. It was odd because I could see the comment being there and even a reply button. |
2 participants
I've found out how the shops on the main street are unlocked, so I added this feature to the "Shops" tab :)
Everything is tested on ACNL:WA, but the old version should work as well.