This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Customizable message CSS classes#16
Open
TheRusskiy wants to merge 2 commits intomarcorinck:masterfrom
Open
Conversation
Author
|
damn... Your last activity was long ago and I want to use this package with bower, but I have no idea how to point bower to a branch other than the master, so another 'bower config change' commit is stuck to this pull request. |
|
👍 would also like to see the class names to be customizable! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, idea of this change is ability to specify what CSS classes I want to use for my messages.
Right now classes are hard-coded to bootstrap.
But it's common to use other frameworks and, since I can't change code of a framework, I want to manually wire my message classes to them.
Also in this commit I provided some tests due to previous lack of such.
No breaking changes, all classes are set bootstrap in default.