fix: Resolve AntD deprecation warnings across the codebase #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Space `direction` prop with `orientation` (18 occurrences in 14 files)
- Replace Select `onDropdownVisibleChange` with `onOpenChange` (2 files)
- Replace Alert `message` prop with `title` (12 files)
- Fix useForm disconnection in auth-modal.tsx by adding `forceRender: true`
to tab items and using `destroyOnHidden={false}` on Tabs
These changes eliminate the following console warnings:
- [antd: Space] direction is deprecated. Please use orientation instead.
- [antd: Select] onDropdownVisibleChange is deprecated. Please use onOpenChange instead.
- [antd: Alert] message is deprecated. Please use title instead.
- Instance created by useForm is not connected to any Form element.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Claude Review✅ Ready to merge - No significant issues found. This PR correctly addresses AntD v6 deprecation warnings with straightforward prop renames ( |
…nnected Since forceRender: true ensures both forms stay mounted in the DOM, the conditional reset logic was unnecessary and could leave stale data in the non-active form. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
directionprop withorientation(18 occurrences in 14 files)onDropdownVisibleChangewithonOpenChange(2 files)messageprop withtitle(12 files)forceRender: trueto tab itemsDetails
These changes eliminate the following console warnings that appeared during navigation:
[antd: Space] direction is deprecatedorientation[antd: Select] onDropdownVisibleChange is deprecatedonOpenChange[antd: Alert] message is deprecatedtitleInstance created by useForm is not connectedforceRender: trueto tab itemsTest plan
npm run lint- no new errors introduced🤖 Generated with Claude Code