Open
Conversation
Owner
|
Hi, @doncem! The overall idea looks fine to me. Do you need any help? |
Author
|
repo needs unit test upgrade to allow php5 and php7 support in travis. for php7 it picks up PHPUnit v6.x which only supports this version. you can see in build report. could work on a hack to apply in this PR but lacking time last couple days and probably best to make more solid decision and code change so |
Owner
|
Ok. I'll try to add phpunit as a dev dependency ASAP there is time, so we won't depend on Travis environment anymore. |
Author
|
There is a "one-liner" solution: |
Repository owner
deleted a comment
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
personally, not fancying the addition of the public function to the ParserInterface, kind of breaks the abstraction "parser should not know a thing about the types". but the fact of having a lookup is very helpful