Change the environment detection to use a config setting#2
Open
ksakhamuri wants to merge 1 commit intomarcelog:masterfrom
Open
Change the environment detection to use a config setting#2ksakhamuri wants to merge 1 commit intomarcelog:masterfrom
ksakhamuri wants to merge 1 commit intomarcelog:masterfrom
Conversation
Owner
|
Hi @ksakhamuri, thanks for the contribution! I'm not sure that I agree on adding yet another option (and moreover in naming it "mix_env"). The solution should look more like checking if Mix is somehow there, and then try to or avoid to use Mix.env. Otherwise besides specifying the environment variable MIX_ENV, one should also duplicate this config in the new :mix_env option. Makes sense? |
kiere
pushed a commit
to kiere/elixir_authorizenet
that referenced
this pull request
Feb 26, 2019
…ransaction Create customer profile from transaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change definitely works for the tests and also for the release build. So, hopefully, this is a good enough change.