Open
Conversation
Creating/Destroying the otel_exporter_pid for each test was not cooperating with all the tests running simultaneously. Almost certainly due to the race condition in OtelHlper.otel_pid_reporter altering the global state to configure where the spans were being sent Co-authored-by: Gray <surrsurus@users.noreply.github.com>
Did this because the first test was always failing Co-authored-by: Gray <surrsurus@users.noreply.github.com>
Owner
|
Hey @jeffdeville, I'm just getting around to these PRs. Thanks for the work you've done here! Could you give me an example of when you'd want arbitrary static attributes? I'm trying to weigh the added complexity of additional option against calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does 2 things:
Note If the input parameters tried to set a span attribute that was also set via the
attributeskey, the explicitly set values inattributestake precedence.