Make PDF differences PNG output optional#34
Open
sudohalt wants to merge 6 commits intomarcdacz:masterfrom
Open
Make PDF differences PNG output optional#34sudohalt wants to merge 6 commits intomarcdacz:masterfrom
sudohalt wants to merge 6 commits intomarcdacz:masterfrom
Conversation
Add condition to use outputPngDifferences
Owner
|
hey @sudohalt thanks for adding this change. before we merge it, can I ask a quick favour to add a README change as well to ensure people knows about this config? thanks in advance |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDFs that have differences when using the
byImagecomparison will output a PNG into adatafolder. The outputting of PNGs should be optional. An example use case is when running tests you only care if two PDFs are identical, and need a true/false response (but don't need the actual differences). UsingbyBase64doesn't work because two PDFs can be identical but have differentbase64representations (different creation date or file name for example).