Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a performance test of encoding and decoding the notoriously complex boundary of the Navajo Nation from the 2020 U.S. Census.
As a proof of concept (but mostly so it’s easy to retrieve later), I also added baselines from v1.2.0 on my local machine for comparison with the current state of the main branch. The existing performance tests, which repeatedly encode and decode a very simple feature collection, have gotten slightly worse (within 10% worse) as of main, but the new tests, which encode and decode the very complex feature collection just once, has gotten slightly better (within 10% better). The exact figures aren’t very stable so it’s nothing more than a gut check of the significant changes that have recently gone into Turf’s GeoJSON support.
/cc @mapbox/navigation-ios