Skip to content
This repository was archived by the owner on Apr 16, 2024. It is now read-only.

Add syntaxes option to register new syntaxes#32

Open
mertyildiran wants to merge 7 commits intomapbox:mainfrom
mertyildiran:main
Open

Add syntaxes option to register new syntaxes#32
mertyildiran wants to merge 7 commits intomapbox:mainfrom
mertyildiran:main

Conversation

@mertyildiran
Copy link
Copy Markdown

@mertyildiran mertyildiran commented Jan 12, 2022

Adds an option named syntax to provide a way to register a new Prism language definition. See.

@hugoclrd
Copy link
Copy Markdown

Awesome @mertyildiran, exactly what I was looking for 👍
Would be great to this it merged and release.

Although it works great for my use case, shouldn't it be syntaxes: refractor.RefractorSyntax[]? So that multiple syntaxes could be registered?

@mertyildiran mertyildiran changed the title Add syntax option to register a new syntax Add syntaxes option to register new syntaxes Jan 24, 2022
@hugoclrd
Copy link
Copy Markdown

Tested on a personal project, works great 💯

@hugoclrd
Copy link
Copy Markdown

hugoclrd commented Feb 7, 2022

Is this repo still maintained @katydecorah @davidtheclark? (Sorry I'm not really sure who to mention)

@mertyildiran
Copy link
Copy Markdown
Author

@hugocaillard I thought you were one of the maintainers.

@davidtheclark
Copy link
Copy Markdown
Contributor

I'd recommend forking the library if you'd like to move it forward.

@mertyildiran
Copy link
Copy Markdown
Author

@davidtheclark yeah, I know but this is a dependency of a dependency for me. So I need to fork two libraries which I don't want to do that. See uiwjs/react-textarea-code-editor#85

I'll have to do that only if I cannot made them merged in a reasonable time.

@mertyildiran
Copy link
Copy Markdown
Author

@katydecorah any update on this PR?

@katydecorah
Copy link
Copy Markdown
Contributor

@mertyildiran I no longer work at Mapbox and unfortunately I'm not sure who will maintain this repository moving forward.

@mertyildiran
Copy link
Copy Markdown
Author

@katydecorah I understand. Thank you so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants