This repository was archived by the owner on Dec 3, 2018. It is now read-only.
Report gzip content-encoding for vector.pbf response #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: without this fix downloading tiles in chrome would produce corrupt files:
|
Member
|
👍 |
This was referenced Mar 2, 2015
Contributor
Author
|
merging now, tests in followup #1240 |
springmeyer
pushed a commit
that referenced
this pull request
Mar 6, 2015
Report gzip content-encoding for vector.pbf response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a holdover from pre-gzip days.
@yhahn - can you give me a tip for where best to add a test for this? I've looked around middleware.test.js, source.test.js, and test-client.js but its opaque to me where the right place would be to query a source via url and assert on its content-encoding.