Skip to content

Round 2 of improving Gabbar documentation #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkowshik wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Round 2 of improving Gabbar documentation #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf53471
Update picture on README to match example along with some coolness
Jul 10, 2017
a3db5f1
Fixed some linting errors
Jul 19, 2017
ae1b845
Add contribution guidelines
Jul 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Contributing to Gabbar


:tada: *Thank you for taking the time to contribute!* :tada:


## Development
```bash
# Code linting
npm run lint
```
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ npm install

## Prediction

<img width="919" alt="screen shot 2017-06-30 at 4 17 46 pm" src="https://user-images.githubusercontent.com/2899501/27732638-ce026614-5daf-11e7-900b-caff399a9da9.png">
<img width="928" alt="screen shot 2017-07-10 at 4 59 03 pm" src="https://user-images.githubusercontent.com/2899501/28016300-6ea4cf06-6591-11e7-8572-a17ac98f2aa0.png">


```bash
Expand Down
6 changes: 3 additions & 3 deletions datasets/analyze-predictions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const argv = require('minimist')(process.argv.slice(2));
const fs = require('fs');
const path = require('path');

const OSMCHA_URL = 'https://osmcha.mapbox.com/'
const OSMCHA_URL = 'https://osmcha.mapbox.com/';

if (!argv.predictionsDir) {
console.log('');
Expand Down Expand Up @@ -56,7 +56,7 @@ while (true) {
// If changeset is already seen, skip.
if (goodChangesets.has(good.changeset_id)) continue;

console.log(OSMCHA_URL + good.changeset_id + '/' + '\t' + getFeatureHash(good) + '.json');
console.log(OSMCHA_URL + good.changeset_id + '/\t' + getFeatureHash(good) + '.json');
goodChangesets.add(good.changeset_id);
}

Expand All @@ -73,6 +73,6 @@ while (true) {
// If changeset is already seen, skip.
if (harmfulChangesets.has(harmful.changeset_id)) continue;

console.log(OSMCHA_URL + harmful.changeset_id + '/' + '\t' + getFeatureHash(harmful) + '.json');
console.log(OSMCHA_URL + harmful.changeset_id + '/\t' + getFeatureHash(harmful) + '.json');
harmfulChangesets.add(harmful.changeset_id);
}
2 changes: 1 addition & 1 deletion datasets/extract-feature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ for (let version of versions) {
let newVersion = version[0];
let oldVersion = version[1];

if ((newVersion.properties.type == argv.featureType) && (newVersion.properties.id == argv.featureID)) {
if ((newVersion.properties.type === argv.featureType) && (newVersion.properties.id === argv.featureID)) {
console.log(JSON.stringify(turf.featureCollection(version), null, 4));
process.exit(0);
}
Expand Down