Skip to content
This repository was archived by the owner on Oct 25, 2023. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/processor.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const reindent = require('./reindent');

const sourceToLineMap = new Map();
const snippetRegexp = /(<script[\s\S]*?>)([\s\S]*?)<\/\s*?script>/g;
const typeAttrRegexp = /type=['"](.*)['"]/;

function preprocess(code, filepath) {
const sourceMap = new Map();
Expand All @@ -18,6 +19,12 @@ function preprocess(code, filepath) {

let currentExtractedCodeLine = 0;
const openingTag = match.subMatches[0];
const typeAttrMatch = openingTag.match(typeAttrRegexp);

if (typeAttrMatch && typeAttrMatch[1] !== 'text/javascript') {
return [];
}

const reindentData = reindent(match.subMatches[1]);

chunkMap.set('indentColumns', reindentData.indentColumns);
Expand Down
22 changes: 22 additions & 0 deletions test/fixtures/html.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,27 @@
var b = "b"</script>

<script></script>

<script type="text/javascript">
var a = 'b';
var b = "b";
</script>

<script type='text/javascript'>
var a = 'b';
var b = "b";
</script>

<script type="application/ld+json">
{
"@context": "https://schema.org/"
}
</script>

<script type='application/ld+json'>
{
"@context": "https://schema.org/",
}
</script>
</body>
</html>
17 changes: 17 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,23 @@ test('html', async (assert) => {
assert.deepEqual(messages[3].line, 16);
assert.deepEqual(messages[3].column, 13);

assert.deepEqual(messages[4].ruleId, 'indent');
assert.deepEqual(messages[4].line, 22);
assert.deepEqual(messages[4].column, 5);
assert.deepEqual(messages[5].ruleId, 'quotes');
assert.deepEqual(messages[5].line, 22);
assert.deepEqual(messages[5].column, 15);

assert.deepEqual(messages[6].ruleId, 'indent');
assert.deepEqual(messages[6].line, 27);
assert.deepEqual(messages[6].column, 5);
assert.deepEqual(messages[7].ruleId, 'quotes');
assert.deepEqual(messages[7].line, 27);
assert.deepEqual(messages[7].column, 15);

// Assert that is does not report errors for ld+json scripts
assert.deepEqual(messages.length, 8);

assert.end();
});

Expand Down