add invalid type validation and test #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpat
reviewed
Jun 16, 2022
cligj/features.py
Outdated
| if newfeat: | ||
| yield newfeat | ||
| else: | ||
| raise TypeError("Type must be Feature or FeatureCollection") |
There was a problem hiding this comment.
Minor comment: the text in this error doesn't seem strictly true - it looks like {"coordinates": ...} will be accepted by line 120, which isn't a "Feature" or a "FeatureCollection".
Author
There was a problem hiding this comment.
Updated to something more generic, "Invalid type" dfd5fa3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following incorrectly formatted geojson source will result in an internal server error:
This PR adds an
elsecase to catch invalid types and raise aTypeErrorNote: looks like the python 3.7 build is failing, but it was in previous commits as well. I wonder why...