Skip to content

Comments

build(deps): bump helm.sh/helm/v3 from 3.17.4 to 3.19.2 in /native#311

Merged
manusa merged 12 commits intomainfrom
copilot/sub-pr-310
Nov 14, 2025
Merged

build(deps): bump helm.sh/helm/v3 from 3.17.4 to 3.19.2 in /native#311
manusa merged 12 commits intomainfrom
copilot/sub-pr-310

Conversation

Copy link
Contributor

Copilot AI commented Nov 13, 2025

Supersedes closes #310

Helm 3.19.2 introduced breaking changes in error messages and logout behavior that broke existing tests.

Error Message Changes

Push operations now return "basic credential not found" instead of "push access denied":

// Updated to accept both formats
.containsAnyOf(
  "push access denied, repository does not exist or may require authorization",
  "basic credential not found"
)

Login failures changed from "login attempt to" to "authenticating to":

.containsAnyOf("login attempt to", "authenticating to")

Debug output format changed - removed specific format assertions that are no longer stable.

Behavioral Changes

Logout no longer throws exception when not logged in - changed test expectation from exception to success message.

Files Modified

  • HelmPushTest.java - Updated push error assertions, removed debug format checks
  • HelmRegistryTest.java - Updated login/logout error expectations
  • native/main_test.go - Updated Go test assertions for consistency

Tests now accept both old and new message formats for backward compatibility.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Contributor Author

Copilot AI commented Nov 13, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • central.sonatype.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire/surefirebooter-20251113143003725_3.jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire 2025-11-13T14-29-42_460-jvmRun1 surefire-20251113143003725_1tmp surefire_0-20251113143003725_2tmp (dns block)
  • charts.example.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire/surefirebooter-20251113143003725_3.jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire 2025-11-13T14-29-42_460-jvmRun1 surefire-20251113143003725_1tmp surefire_0-20251113143003725_2tmp (dns block)
  • charts.gitlab.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire/surefirebooter-20251113143003725_3.jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire 2025-11-13T14-29-42_460-jvmRun1 surefire-20251113143003725_1tmp surefire_0-20251113143003725_2tmp (dns block)
  • charts.helm.sh
    • Triggering command: /tmp/go-build3570512634/b1343/helm.test -test.testlogfile=/tmp/go-build3570512634/b1343/testlog.txt -test.paniconexit0 -test.timeout=10m0s (dns block)
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire/surefirebooter-20251113143003725_3.jar /home/REDACTED/work/helm-java/helm-java/helm-java/target/surefire 2025-11-13T14-29-42_460-jvmRun1 surefire-20251113143003725_1tmp surefire_0-20251113143003725_2tmp (dns block)
  • kubernetes.github.io
    • Triggering command: /tmp/go-build3570512634/b1343/helm.test -test.testlogfile=/tmp/go-build3570512634/b1343/testlog.txt -test.paniconexit0 -test.timeout=10m0s (dns block)
  • registry.k8s.io
    • Triggering command: /usr/local/bin/containerd (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Bump helm.sh/helm/v3 from 3.17.4 to 3.19.2 Fix test failures after Helm 3.19.2 upgrade Nov 13, 2025
Copilot AI requested a review from manusa November 13, 2025 14:41
dependabot bot and others added 4 commits November 13, 2025 16:47
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.4 to 3.19.2.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.17.4...v3.19.2)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-version: 3.19.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: manusa <488391+manusa@users.noreply.github.com>
@manusa manusa force-pushed the copilot/sub-pr-310 branch from 19e49c6 to 564e71c Compare November 13, 2025 15:47
@manusa manusa changed the base branch from dependabot/go_modules/native/helm.sh/helm/v3-3.19.2 to main November 13, 2025 15:48
@manusa manusa changed the title Fix test failures after Helm 3.19.2 upgrade build(deps): bump helm.sh/helm/v3 from 3.17.4 to 3.19.2 in /native Nov 14, 2025
@manusa manusa marked this pull request as ready for review November 14, 2025 11:31
@manusa manusa merged commit 60790f3 into main Nov 14, 2025
3 checks passed
@manusa manusa deleted the copilot/sub-pr-310 branch November 14, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants