feature: allow providing kubeconfig from string#217
Conversation
|
Thanks for contributing, I'll review deeper as soon as I get some time. From the first look, I think I'd prefer an approach where the On the other hand, your current approach is quite convoluted and might have multiple unwanted side-effects for more complex configurations. I'm not sure if you ported the client-go instantiation from |
|
Thanks for the first feedback. I totally understand your concerns about my approach. I did choose this over a temporary file, like you said for security reasons. If you think these concerns are unnecessary let me know and I can change the implementation. |
e03473f to
ec4f773
Compare
|
After a few hours of digging into client-go's source code I think I managed to find a simple solution that is both secure and sustainable in the future. Please take a look to see if this works for you. The tests seem to be passing fine. I think another iteration is needed to make it work completely fine without side-effects, but it should probably be tackled as a separate pull request. |
|
Thanks for your work, this works completely fine for our use case (#52 (comment)) - looking forward to use the release :) |
This should resolve #52 , providing the option to use the contents of a kubeconfig instead of a file directly.
Disclaimer: I'm no go expert so the tests are a bit spartanic.