Add suport for adding a prefix to module exports #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend the module system to support prefixing exported symbols with a user-provided symbol. For example, the following prefixes all of the exports from the test module with t-. (import (:prefix t- test)) You can also prefix an explicitly specified set of symbols: (import (:prefix t- doit fizzbuzz test)) In this case, doit and fizzbuzz are available as t-doit and t-fizzbuzz. The pre-exisiting alias functionality is still available and takes precendence. (import (:prfix t- (my-doit doit) fizzbuzz test)) In the above, doit is available as my-doit and fizzbuzz as t-fizzbuzz
Owner
|
Hi Joseph, Sorry for having being so slow to accept your pull request. There is now a minor conflict because I have had to fix the eval module implementation. In order not to slow down the release of 4.3h, I propose to postpone the integration of your pull request. I will release 4.3h and right after that integrate your pull request. |
Contributor
Author
|
I am fine with postponing the integration, and I corrected the merge conflict you noted. Let me know if anything additional is required. Thanks, |
This method was causing a java compilation error and is not used anywhere, so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend the module system to support prefixing exported symbols with a
user-provided symbol. For example, the following prefixes all of the
exports from the test module with t-.
(import (:prefix t- test))
You can also prefix an explicitly specified set of symbols:
(import (:prefix t- doit fizzbuzz test))
In this case, doit and fizzbuzz are available as t-doit and
t-fizzbuzz.
The pre-exisiting alias functionality is still available and takes
precendence.
(import (:prefix t- (my-doit doit) fizzbuzz test))
In the above, doit is available as my-doit and fizzbuzz as t-fizzbuzz