Open
Conversation
added 2 commits
October 7, 2016 11:00
- add build phase - adapt script outcome: the script is executed and dsym is uploaded
Owner
|
@davidcyp Thank you for all your efforts, please resolve the conflicts before I could merge this. |
…ios_run_hook_add_shellscript # Conflicts: # plugins/ti.fabric/cli/hooks/run.js
Author
|
@manojdcoder done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
We had trouble getting the shellScript running. After some investigation, we found out there was no 'Post-Compile' phase defined in our project.pbxproj. Because of that, the shellScript was not added to our project.pbxproj and the dSYM was not uploaded to the Fabric.io backend.
Therefore, we have rewritten the code which alters the project.pbxproj and now everything works fine. However, we guess the previous version of the script must have worked in the past, thus we are not sure we can simply override it by this version. Can you verify if our new version of the script doesn't break things.
For the sake of completeness, I have also added the steps we execute to register an app for the 1st time:
Kind regards,
David