Add option to pass non matching XmlNodes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
All tests passed on local btw. |
Fix pass_all_nodes method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request allows to stream non matching nodes.
In my case
<tu></tu>nodes are interesting<anyothers />are not interesting but cannot be dropped.Final outcome is a modified XML file.
I'm not sure this pull-request is interesting or breaks the spirit of your library. It adds an option to stream the non matching nodes.
As we're streaming both matches and non matches the receiving stream will need to verify the type before processing or just pass the values along.
I tried to keep your coding standards but felt the if's were not a bad choice, my editor enter some spaces sorry about that.