forked from irc-archive/ratbox-mirror
-
Notifications
You must be signed in to change notification settings - Fork 2
Sync 20260208 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sync 20260208 #29
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b999e18
Bail on zero length buffer to rb_linebuf_get
mannfredcom b9bdb7a
Assert invalid buflen
mannfredcom 0e5ac8b
lrb_assert for invalid buflen
mannfredcom 36b610b
Added tls1.3 in example.conf
mannfredcom ac7e7ab
Correct start index for parse_nameservers
mannfredcom 342c2ed
fix assert
synandro 36301a1
Merge pull request #18 from synandro/fix/correct-parse-nameservers-index
synandro 71e97eb
Merge pull request #17 from synandro/fix/rb-linebuf-get-zero-safety
synandro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
lrb_assert(buflen > 0)inrb_linebuf_getwill abort in builds withoutSOFT_ASSERTwhenbuflenis 0. This is reachable instart_zlib_session(src/sslproc.c) because it callsrb_linebuf_getin ado { ... } while (cpylen > 0)loop withleft = recvqlen, andrecvqlencan be 0 when no data is queued. In that case the first call passesbuflen==0and the process asserts, which is a regression from the previous behavior where empty queues were tolerated. Consider early-returning onbuflen==0or skipping the call whenrecvqlen==0.Useful? React with 👍 / 👎.