Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 281012eb50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| size_t len = strlen(src); | ||
| size_t res = dsize + len; | ||
|
|
||
| assert(dsize >= count); |
There was a problem hiding this comment.
The new assert(dsize >= count) is inverted: in normal, safe use of rb_strlcat, dsize is usually less than count. This assertion will therefore abort debug builds on valid inputs (e.g., when there is room in the destination buffer), while it does nothing to guard the actual overflow case (dsize >= count, which should short-circuit or return). This changes behavior from “works in release and debug” to “debug-only crash” for standard usage.
Useful? React with 👍 / 👎.
2 participants
No description provided.