Skip to content

Conversation

@maniac-en
Copy link
Owner

Summary

  • Updates CI workflow to handle Go formatting via PR comments instead of direct commits to main
  • Format check now only runs on pull requests and tags the PR author when formatting is needed
  • Removes auto-commit behavior that was conflicting with branch protection rules

Changes

  • Format check job now runs only on pull_request events
  • Comments on PR with list of unformatted files and tags author
  • Main branch pushes only run build/test jobs (no format check since code is pre-validated)

Test Plan

  • This PR itself will test the new format check workflow
  • Future PRs will use the updated workflow for format validation

- Format check now only runs on pull requests
- Comments on PR with unformatted files and tags author
- Removes auto-commit behavior that conflicted with branch protection
- Main branch pushes only run build/test jobs
- Simplify PR comment message to avoid multiline string issues
- Link to action logs for file details instead of listing in comment
@github-actions
Copy link
Contributor

@maniac-en Go code formatting is required. Please run go fmt ./... to format your code and push the changes. Check the action logs for details on which files need formatting.

@maniac-en maniac-en merged commit dbdc407 into main Aug 24, 2025
4 checks passed
@maniac-en maniac-en deleted the fix/workflow-format-check branch August 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants