Open
Conversation
Ignoring libraries and mac osx dir files
The backend misses the typescript definition for the cors objects
- Since the project is using mongodb v: 7.0.0 or above, There is not need for using: useNewUrlParser and useUnifiedTopology. - Also, the schema and models has been included
- Declaring the Task Module definition using an approach similar to Nest JS (Modular Architecture)
It's located on the config path. Also, bodyParser is not longer needed due to the current version for express: 4.18.2 or superior
This will ensure the SoC and SRP.
Both task.service, for handling the interaction to the database and the controller, for establish a bridge between the routes and the service have been integrated.
Refactor: Applying some standars on code
Now the code handles validations through a Middleware (By using Joi library), before they access the controllers.
The following json is the standard body:
{
message, data
}
Now the Business logic is covered with unit test. Jest is used for both unit test and code coverage.
React hooks have been imported.
Following the Feature-Sliced Architecture
Handling hooks on Task feature. Delegating the api route on Config environment. Creating TaskItem component.
- Tailwind fully integrated - Cleaning remaining styles (Like page.module.css) - Adding Tailwind general Style - Integrating Mongo DB Atlas for remote conecction (This one has a dependency with .env)
Also some tailwind styles were included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the full implementation of the TODO application, featuring both the backend (Node.js + Express + MongoDB + Jest) and the frontend (Next.js 14 + Tailwind CSS + Jest + Testing Library).