ci: pin pip-audit action SHAs and update to v1.1.0#2884
ci: pin pip-audit action SHAs and update to v1.1.0#2884kami922 wants to merge 2 commits intomandiant:masterfrom
Conversation
After adding tests/__init__.py, conftest.py needs relative imports
Summary of ChangesHello @kami922, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration pipeline by standardizing the use of pinned commit SHAs for GitHub Actions, thereby increasing the reliability and security of the workflows. It also updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request pins GitHub Action versions in the CI configuration to specific commit SHAs for improved security and build stability, and updates pypa/gh-action-pip-audit to v1.1.0. A changelog entry has been added to reflect this. Additionally, a small change in tests/conftest.py converts imports to be explicit relative imports. The provided code changes are correct and I have no further feedback.
| from .fixtures import * # noqa: F403 [unable to detect undefined names] | ||
| from .fixtures import _692f_dotnetfile_extractor # noqa: F401 [imported but unused] | ||
| from .fixtures import _1c444_dotnetfile_extractor # noqa: F401 [imported but unused] | ||
| from .fixtures import _039a6_dotnetfile_extractor # noqa: F401 [imported but unused] | ||
| from .fixtures import _0953c_dotnetfile_extractor # noqa: F401 [imported but unused] |
There was a problem hiding this comment.
are these changes related/required?
There was a problem hiding this comment.
Please remove these changes if not required.
|
@kami922 tests are failing. Please ensure all tests pass locally before requesting another review. |
3 participants
Fixes #1131
The
pip-audit.ymlworkflow was added previously but both actions were unpinned (using mutable tags), inconsistent with every other workflow in the repo which pins to commit SHAs.Changes
actions/checkout@v4→@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1(same SHA already used intests.yml)pypa/gh-action-pip-audit@v1.0.8→@1220774d901786e6f652ae159f7b6bc8fea6d266 # v1.1.0(latest stable, adds Windows runner support)Checklist