Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,5 @@ | |||
| if-shell '[ -n "#{env:TMUX_SHELL}" ]' 'set-option -g default-shell "#{env:TMUX_SHELL}"' | |||
| if-shell '[ -n "${TMUX_SHELL}" ]' 'set-option -g default-shell "${TMUX_SHELL}"' | |||
There was a problem hiding this comment.
In tmux command arguments, ${TMUX_SHELL} is not expanded because tmux only expands its own format strings (e.g., #{env:TMUX_SHELL}) inside set-option. The if-shell condition runs in /bin/sh so the test works, but the set-option argument becomes the literal string ${TMUX_SHELL} and tmux will try to use that literal as the shell path. This breaks users who set TMUX_SHELL, because tmux won’t pick up their intended shell value.
Useful? React with 👍 / 👎.
1 participant
No description provided.