Apply ParacelsusPharmD's fixes to research JSON files#8
Open
DoomRater wants to merge 2 commits intomallrat208:masterfrom
Open
Apply ParacelsusPharmD's fixes to research JSON files#8DoomRater wants to merge 2 commits intomallrat208:masterfrom
DoomRater wants to merge 2 commits intomallrat208:masterfrom
Conversation
Apparently, there was only a handful of text changes here needed to make things unlock and progress correctly, so making a patch to these two files and filing a pull request to see what's what.
And with that, all the text patches are applied. They should match what's in the code now.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've used ParacelsusPharmD's version of Expanded Arcanum without issue since it was added to my modpack and it's been a wonderful boon to my resource gathering. I think it's about time the fix was applied to the main build so a new version can be compiled to CurseForge. Also, this will address multiple open issues in your tracker, including one I opened.