fix output paths for decoding results #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @toruurakawa Thanks for sending in the pull request. I am not sure entirely if this wouldn't break or overwrite anything during the training and testing process. I'll revisit and review these changes for any possible errors later since this doesn't result in any runtime error. |
Author
|
Thanks for your comment. Certainly it is necessary to make sure the behavior other than the decoding process. |
ashutoshml
requested changes
Nov 26, 2020
Collaborator
ashutoshml
left a comment
ashutoshml
left a comment
There was a problem hiding this comment.
Please add code to create the directory.
"os.makedirs(outdir, exist_ok=True)"
ashutoshml
reviewed
Nov 26, 2020
| param_str= '_'.join(param_str) | ||
|
|
||
| outdir = str(args.out_dir) | ||
|
|
Collaborator
There was a problem hiding this comment.
Please add code to create directory. "os.makedirs(outdir, exist_ok=True)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.