Skip to content

Comments

Masstree Safety: Pointer-to-reference conversions and safety annotations#51

Open
daggergad7 wants to merge 20 commits intomakodb:mako-devfrom
daggergad7:gliston/masstree-safety-dev
Open

Masstree Safety: Pointer-to-reference conversions and safety annotations#51
daggergad7 wants to merge 20 commits intomakodb:mako-devfrom
daggergad7:gliston/masstree-safety-dev

Conversation

@daggergad7
Copy link
Contributor

@daggergad7 daggergad7 commented Dec 14, 2025

Summary

  • Converted few pointer parameters to references where NULL checks were unnecessary
  • Added @safe/@unsafe annotations to all 78 masstree files
  • Fixed annotation collisions for overloaded functions
  • Added @external declarations for external function calls

Current Safety Metrics for Masstree

Metric Count Percentage
@safe 615 55.7%
@unsafe 490 44.3%

@shuaimu
Copy link
Contributor

shuaimu commented Dec 17, 2025

pls also resolve conflicts.

@daggergad7 daggergad7 force-pushed the gliston/masstree-safety-dev branch from 5013d9d to 3c16d35 Compare December 19, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants