Feedback#407

Open

lplclaremont wants to merge 71 commits intomakersacademy:mainfrom

lplclaremont:feedback

Commits on May 21, 2023

setup rspec

Louis Claremont
authored and
Louis Claremont
committed
created first test for frame class

Louis Claremont
authored and
Louis Claremont
committed
passed firat test

Louis Claremont
authored and
Louis Claremont
committed
removed rolls method

Louis Claremont
authored and
Louis Claremont
committed
test written for checking spares

Louis Claremont
authored and
Louis Claremont
committed
passed spare test

Louis Claremont
authored and
Louis Claremont
committed
method for checking strike added

Louis Claremont
authored and
Louis Claremont
committed
added pins down attribute

Louis Claremont
authored and
Louis Claremont
committed
added pins doown attr

Louis Claremont
authored and
Louis Claremont
committed
scoring basic frame test driven

Louis Claremont
authored and
Louis Claremont
committed
added test for valid roll input

Louis Claremont
authored and
Louis Claremont
committed
added test for spare score

Louis Claremont
authored and
Louis Claremont
committed
spare score only updates when new roll been added

Louis Claremont
authored and
Louis Claremont
committed
removed return statements

Louis Claremont
authored and
Louis Claremont
committed
test driven scoring a strike

Louis Claremont
authored and
Louis Claremont
committed
test for adding strike bonus when next frame a strike passed

Louis Claremont
authored and
Louis Claremont
committed
strike bonus handled when next roll alo a strike

Louis Claremont
authored and
Louis Claremont
committed
add spare followed by strike check

Louis Claremont
authored and
Louis Claremont
committed
added test for 3 strikes in a row

Louis Claremont
authored and
Louis Claremont
committed
added tests for tenth frame with 3 rolls

Louis Claremont
authored and
Louis Claremont
committed
created the BowlingGame class

Louis Claremont
authored and
Louis Claremont
committed
added test for adding frames

Louis Claremont
authored and
Louis Claremont
committed
add frames test passed

Louis Claremont
authored and
Louis Claremont
committed
calculates total score for 0 frame

Louis Claremont
authored and
Louis Claremont
committed
added test for gutter game

Louis Claremont
authored and
Louis Claremont
committed
named test context better

Louis Claremont
authored and
Louis Claremont
committed
passed total score test for single frame

Louis Claremont
authored and
Louis Claremont
committed
passed test for finding total with 2 frames

Louis Claremont
authored and
Louis Claremont
committed
added test for 10 frames

Louis Claremont
authored and
Louis Claremont
committed
does not update total score if added frame is a spare

Louis Claremont
authored and
Louis Claremont
committed
changed structure of total_score method

Louis Claremont
authored and
Louis Claremont
committed
passing tests for total score with spares spares

Louis Claremont
authored and
Louis Claremont
committed
passes the total with spares and refactored

Louis Claremont
authored and
Louis Claremont
committed
added another test for strike calculation

Louis Claremont
authored and
Louis Claremont
committed
another test for strike condition

Louis Claremont
authored and
Louis Claremont
committed
test added for spare on last frame

Louis Claremont
authored and
Louis Claremont
committed
refactored current score method

Louis Claremont
authored and
Louis Claremont
committed
test driven strike behavior when start with strike

Louis Claremont
authored and
Louis Claremont
committed
updated README

Louis Claremont
authored and
Louis Claremont
committed
added test for one strike in middle

Louis Claremont
authored and
Louis Claremont
committed
passed test for 5 strike game

Louis Claremont
authored and
Louis Claremont
committed
passed all strike game test

Louis Claremont
authored and
Louis Claremont
committed
refactored

Louis Claremont
authored and
Louis Claremont
committed
require_relative in bowling_game.rb added

Louis Claremont
authored and
Louis Claremont
committed
added index to running total

Louis Claremont
authored and
Louis Claremont
committed
passes final teat

Louis Claremont
authored and
Louis Claremont
committed

Commits on May 22, 2023

refactored strike bonus method

Louis Claremont
authored and
Louis Claremont
committed
added helper function

Louis Claremont
authored and
Louis Claremont
committed
using helper method in test suite to simulate games

Louis Claremont
authored and
Louis Claremont
committed
merged test cleanup into main

Louis Claremont
authored and
Louis Claremont
committed
refactoring score method

Louis Claremont
authored and
Louis Claremont
committed
removing frames pins_down attribute

Louis Claremont
authored and
Louis Claremont
committed
removing comments

Louis Claremont
authored and
Louis Claremont
committed
removing running a game in bowling_game.rb

Louis Claremont
authored and
Louis Claremont
committed
updating README

Louis Claremont
authored and
Louis Claremont
committed
refactoring add_strike_bonus

Louis Claremont
authored and
Louis Claremont
committed
removed simulation of game in the bowling_game file

Louis Claremont
authored and
Louis Claremont
committed
removing redundant or statement in total_up_to(i)

Louis Claremont
authored and
Louis Claremont
committed
removing initial total_up_to for emepty game

Louis Claremont
authored and
Louis Claremont
committed
refactored score_sum method

Louis Claremont
authored and
Louis Claremont
committed
neatening up update_score method

Louis Claremont
authored and
Louis Claremont
committed
checking if score == nil in update_score method

Louis Claremont
authored and
Louis Claremont
committed
refactoring continues

Louis Claremont
authored and
Louis Claremont
committed
removed require from spec helper

Louis Claremont
authored and
Louis Claremont
committed
bowling_game_spec into integration folder

Louis Claremont
authored and
Louis Claremont
committed
adding comments to bowling_game

Louis Claremont
authored and
Louis Claremont
committed
Merge branch 'main' into refactor
lplclaremont
authored
Merge pull request #1 from lplclaremont/refactor
lplclaremont
authored
removing redundant :score attr_reader in frame class

Louis Claremont
authored and
Louis Claremont
committed
removing branches

Louis Claremont
authored and
Louis Claremont
committed
added feedback branch

Louis Claremont
authored and
Louis Claremont
committed