Additional docs; resolve missing pycond when building venv on Pi #259
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…nings) - main.py: replace infinite ZZLOADER wait with configurable readiness (loaderKey, waitForLoader, loaderTimeout); throttle logs; warn then continue - gui.py: remove blocking sleep; quit via short QTimer; unify cleanup for keyboard “X” and window close; stop all QTimers; stop scheduler; call fix.stop() - hmi/menu.py: replace thread-based auto-hide with GUI-thread QTimer; stop timer in closeEvent - instruments/weston/init.py: correct super().closeEvent; shorten QProcess waits; terminate→kill fallback - instruments/gauges/abstract.py: parent blink QTimer to widget; stop in closeEvent; fix indentation regression - screens/screenbuilder.py: stop encoder timer in closeEvent - .gitignore: update ignores result: no false “ZZLOADER missing” loop; faster exit; reduced “QObject::killTimer” warnings; avoid exit-time crashes
- Added configurable ZZLOADER wait with timeout to prevent infinite startup loop - Fixed cross-thread QTimer warnings during application exit - Implemented proper scheduler thread shutdown sequence using QMetaObject.invokeMethod - Queue timer stops in scheduler thread with non-blocking QueuedConnection to avoid deadlocks - Split exit sequence into doExit() and _finishExit() for proper async cleanup - Fixed Weston closeEvent super() call syntax error - Added closeEvent handlers to menu, abstract gauges, and screenbuilder to stop timers - Ensured FIX client threads stop before Qt cleanup - Reduced exit delays and eliminated blocking waits during shutdown - All exit methods (keyboard 'X' and window close) now exit cleanly without warnings
|
I see you closed this, do you still want to get it merged? I've only briefly looked at this in my browser. My only concern so far is a lack of unit tests. If you need help with adding tests let me know. Feel free to reopen this and we can work together to get this merged. |
|
@e100 I've made some further mods to both the fixGw (my repo: master) and pyEfis (my repo: new_ems_gauges) projects, some files attached. I re-worked the fixGwClient GUI app and made some improvements to the pyEfis gauges (input throttling added) and pyEfis button logic (kudos to you for that and the awesome screenbuilder). Truth be told, Github Copilot is helping - after 40+ years in the real-time software development world the modern day capability of LLMs is truly remarkable. A critical eye on the output is still required...but happy to let the younger kids/agents do the heavy lifting :-) |
2 participants
No description provided.