Merged
Conversation
makaimann
force-pushed
the
re-enable-features
branch
from
2f45dfc to
6e186e3
Compare
Collaborator
|
are we going to merge this? |
Owner
Author
|
I'm not sure yet. Do you think we should evaluate it more first? |
Collaborator
|
i want this https://github.com/makaimann/prophic3/pull/36/files#diff-24291604882058303989f62447f8c16dR87 to be merged. Not sure about the remaining |
This reverts commit 1c3136e.
Owner
Author
|
Makes sense! I reverted the index flattening which is what I'm not sure about and made a separate PR for that which we can wait to merge: #38 We can merge this if you think it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add back some features that were removed temporarily and fix configurations