Created unified ci.yml with linting, automated releases, and Linux builds; Updated README.md#126
Conversation
- Consolidated Windows and macOS builds into a single matrix-based workflow - Added Linux (PyInstaller) build support and [linux.spec](cci:7://file:///home/terra/Qtcord/helper_scripts/linux.spec:0:0-0:0) - Integrated Ruff for automated linting and formatting checks - Added automated GitHub Releases on tag pushes (v*) - Removed requirement for external Discord tokens in the build process - Cleaned up legacy workflow files
…errors - Replaced separate build workflows with a single ci.yml - Added Linux build support with linux.spec - Added ruff.toml config (excludes auto-generated UI files) - Fixed 108 lint/format issues across all source files - Added build artifacts to .gitignore - Automated GitHub Releases on version tags
|
I also Adjusted the readme to be better for new people / non tech literal. |
|
"Unfortunately this is broken on the Flatpak builds. I’m not sure how to fix this yet"~ |
mak448a
changed the title
|
I made a few changes and cut down the "bloat" of the README. Also, not everything needs to be centered or HTML, so I reverted that change on the source notice. |
|
By the way, generally I like to keep comments and code concise, descriptive, and readable. The ruff.toml said "exclude auto-generated files" twice, so I removed it. It also listed every file explicitly but none of the files in that directory should be formatted, so I removed that. |
|
I removed "Secure by design" since I wouldn't go as far as to make it a selling point just because it uses the system keyring. |
|
I still cant find why it doesnt build on flatpak |
The other pr had AI description (+weird decisions to remove perfectly fine stuff) so I closed it |
wasnt on about your repo but yeah those ai prs do just waste time |
It builds, but the keyring library doesn't have the portal built into it so the app never launches. See flathub/io.github.mak448a.QTCord#75 (comment) |
how would we resolve this |
|
I was thinking maybe somehow figure out how to implement it with https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Secret.html through PySide6.QtDBus? I have no idea but I think portals might be able to be called from dbus? |
|
Idk about the readme redo, I like some aspects but I felt it was getting too long before the download button. So I removed the image and cut down on it a bit. Hopefully it still looks okay to you 😅 |
Yep its okay i just had to take some time off because various irl factors but im back |
|
I am back and willing to work on this pr again. What do you want me to modify/adjust |
mak448a
changed the title
mak448a
added
documentation
|
Thank you for the pull request! I merged it |
2 participants
Closes #89
I followed CONTRIBUTING.md