Replace RWMutex with sync.Once and atomic int, reuse error#11
Open
aviddiviner wants to merge 1 commit intomailgun:masterfrom
Open
Replace RWMutex with sync.Once and atomic int, reuse error#11aviddiviner wants to merge 1 commit intomailgun:masterfrom
aviddiviner wants to merge 1 commit intomailgun:masterfrom
Conversation
Author
|
I'm posting the PR here because it seems like braintree/manners has become a little abandoned, and this fork is where the magic is happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think of this little tweak?
Replaced the
sync.RWMutexwith async.Onceso then I can check for isClosed() on an atomic int. This makes it cheap to check before each Accept() so we don't need to error out unnecessarily on the underlying listener.Also, it's always nice to delete more code than you add :)