Skip to content

Conversation

@svenluijten
Copy link
Contributor

@svenluijten svenluijten commented Jul 2, 2025

This PR ensures the created subaccount is available to consumers of this API without having to make a new request. According to the docs, the POST /v5/accounts/subaccounts endpoint returns the created subaccount, so we'll use the already existing model in the project to return it.

@svenluijten svenluijten force-pushed the subaccounts-create-response-model branch from da8a095 to 243410d Compare July 2, 2025 07:21
@svenluijten
Copy link
Contributor Author

It should be noted that this is a breaking change, as the $message property was previously filled with the response. But it made no sense that I had to call ->getMessage() to get the response body. I figured a separate ->getItem() method that returns the domain model works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant