Vulnerability issue fix#411
Conversation
…fix from github for a dependency
|
r? @ustulation (maidsafe_highfive has picked a reviewer for you, use r? to override) |
hunterlester
left a comment
There was a problem hiding this comment.
That tutorial is using npm, so either package-lock.json should remain and yarn.lock removed or yarn instructions should replace npm instructions.
Must update the instructions to use yarn. Also package.json must reflect the same.
|
The only reason why I didn't introduce yarn was to keep it simple to starters, so they don't need to install yarn, and also for something like this doesn't need to be that efficient as it doesn't download too many things, so I'd vote for keeping it simpler with just npm. |
|
I was trying to fix this by forcing the version of the nested dependency So it seems we don't have much choice but to wait for a new release of our direct dependencies where they upgrade |
Removed
package-lock.jsonfile to get the vulnerability issue fix from github for a dependency's dependency