Skip to content

MAkefile support and compiler warnings#25

Open
brianwalenz wants to merge 4 commits intomaickrau:masterfrom
brianwalenz:master
Open

MAkefile support and compiler warnings#25
brianwalenz wants to merge 4 commits intomaickrau:masterfrom
brianwalenz:master

Conversation

@brianwalenz
Copy link

I split the existing CXXFLAGS into multiple lines, added a few -Wno options, and removed redundant -lpthread from the link. The rest of the changes are pretty simple.

Compilation:

  • Linux RHEL 8.9 is clean.
  • MacOS has not been tested.
  • FreeBSD 13.2 (gcc9) is clean.
  • FreeBSD 13.2 (clang14) still reports:
    src/HashList.h:47:9: warning: private field 'kmerSize' is not used [-Wunused-private-field]
            size_t kmerSize;
                   ^
    1 warning generated.
    

Execution has NOT been tested yet. No need to merge until it is tested, and I guess MacOS too. MacOS arm is known broken, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant