Skip to content

API Querying in React #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maiano wants to merge 6 commits into
base: app-state-management
Choose a base branch
from
Open

API Querying in React #5

maiano wants to merge 6 commits into from

Conversation

@maiano
Copy link
Owner

@maiano maiano commented Aug 10, 2025 •
edited
Loading

  1. Task: link
  2. Screenshot:
Screenshot 2025-08-11 at 01 48 16
  1. Deploy: link
  2. Done 11.08.2025 / deadline 11.08.2025
  3. Score: 100 / 100
  • Query library (RTK Query or TanStack Query) is properly implemented - 25
  • All API calls are converted to use the query library - 20
  • Loading states are properly handled and displayed - 15
  • Error states are properly handled and displayed - 10
  • Cache invalidation and refetching work correctly - 20
  • Manual cache invalidation control works as expected - 10

@kosmodromm kosmodromm self-requested a review August 20, 2025 19:15
kosmodromm
kosmodromm approved these changes Aug 20, 2025
View reviewed changes
src/components/Footer.tsx
Comment on lines +6 to +7
<footer className="px-4 pb-4 flex justify-end gap-4">
<RefreshButton queryKey={['characters']} />
Copy link
Collaborator

@kosmodromm kosmodromm Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

несмотря на то, что ключ один, хорошо бы запихнуть его в константу или объект QUERY_KEYS "навырост"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kosmodromm kosmodromm kosmodromm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maiano @kosmodromm