replace ocamlbuild by dune + update code + autoformat code#11
Open
grazil wants to merge 1 commit intomahsu:masterfrom
Open
replace ocamlbuild by dune + update code + autoformat code#11grazil wants to merge 1 commit intomahsu:masterfrom
grazil wants to merge 1 commit intomahsu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I update the project because I could compile it.
I decide to use dune as it is recommand on the ocamlbuild website to make the change.
I modify the source code to make it work with the last version of js_of_ocaml.
I use ocamlformat to unify the code formatting.
Hope you will accept my merge request.
Thanks for this wonderfull project and have a nice day !