review(cli): code review response for TUI defaults and positional path shortcuts#24
Closed
Copilot wants to merge 1 commit intocursor/tui-watch-path-handling-3694from
Closed
review(cli): code review response for TUI defaults and positional path shortcuts#24Copilot wants to merge 1 commit intocursor/tui-watch-path-handling-3694from
Copilot wants to merge 1 commit intocursor/tui-watch-path-handling-3694from
Conversation
|
|
Copilot
AI
changed the title
[WIP] Fix TUI defaults and clearer --watch handling
review(cli): code review response for TUI defaults and positional path shortcuts
Mar 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cursor/tui-watch-path-handling-3694 #24 +/- ##
====================================================================
Coverage 90.14% 90.14%
====================================================================
Files 13 13
Lines 1420 1420
====================================================================
Hits 1280 1280
Misses 140 140 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to
@copilot reviewon the PR adding TUI defaults and positional CLI shortcuts. All CI checks pass (Tests ✅, Lint ✅, 127 tests).Review findings
No blocking issues. Changes are correct, well-tested, and backward-compatible.
What looks good
DEFAULT_METRICS_JSONL_FILENAMEconstant inmetrics_stream.pyis the right single source of truth for the worker↔TUI filenameinject_cli_positional_pathsand its private helpers are pure functions, easily testable in isolationsys.argvmutation inmain()is properly guarded byfinallyrestoration--watchvaluesdeve2e, TUI help output, and default-path resolutionMinor nits (non-blocking)
inject_worker_positional_pathsdocstring says "backward-compatible alias" but both functions were introduced together; "public alias" is more accurate_QUICKSTART_EPILOGwording is slightly awkward — suggest condensing to:_inject_worker_start_dev_console— the mixed-mode edge case (explicit--agents-dir+ a bare second token) falls through to Typer's "unexpected argument" error; a short code comment would clarify this is intentional⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.