Save quote to cart repository#162
Open
JeroenBoersma wants to merge 2 commits intomagmodules:masterfrom
Open
Conversation
Save the quote as soon as posible to the cart repository to make sure it will become generally available during the execution of code. ````php $quote->save(); // does not register the quote in the repository // ... snap \Magento\Quote\Model\QuoteManagement::placeOrder($quote->getId()); // this will reload the quote ``` `$quote->setInventoryProcessed` is a in memory field only and the state is lost when it will be reloaded from the database
in the repository the current item is unset instead of set/overwritten force object reload and registering in memory same quote object is used for the placeOrder
Author
|
Please wait merging... We run into a problem where customer addresses break if a customer exists and the shipping country is changed. The final order will have the wrong address, our investigation took several days, so need to come back at this at a later time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save the quote as soon as posible to the cart repository to make sure it will become generally available during the execution of code.