Refactor: Extract duplicated task waiting logic into helper method

[Copilot]

Addresses code duplication in MainViewModel.Dispose() where two nearly identical try-catch blocks wait for tasks to complete before disposal.

Changes

• Added WaitForTaskCompletion() helper method to encapsulate task waiting, timeout handling, and exception logging
• Replaced 55 lines of duplicated code with two method calls
• Moved #pragma warning disable VSTHRD002 into the helper method to suppress warnings at the appropriate scope

Before/After

Before:

try
{
    if (_updateMouseHookRectsLoopTask is not null
        && !_updateMouseHookRectsLoopTask.IsCompleted
        && !_updateMouseHookRectsLoopTask.Wait(TimeSpan.FromSeconds(5)))
    {
        _logger.LogWarning("Update mouse hook rects loop task did not complete within timeout");
    }
}
catch (AggregateException ae) { /* ... */ }
catch (Exception e) { /* ... */ }

// Duplicate block for _mouseEventProcessingLoopTask

After:

WaitForTaskCompletion(_updateMouseHookRectsLoopTask, "Update mouse hook rects loop task", TimeSpan.FromSeconds(5));
WaitForTaskCompletion(_mouseEventProcessingLoopTask, "Mouse event processing loop task", TimeSpan.FromSeconds(5));

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR successfully refactors the MainViewModel.Dispose() method by extracting duplicated task waiting logic into a reusable helper method, reducing code duplication from 55 lines to 2 method calls.

Key Changes:

• Introduced WaitForTaskCompletion() private helper method to encapsulate task waiting, timeout handling, and exception logging
• Refactored Dispose() to use the helper method for both task waiting operations
• Moved #pragma warning disable VSTHRD002 directive into the helper method scope

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.