[EXPERIMENTAL] Dev docker fixes dom2022 #108
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync to master (ignore this)
- change from 'collections' to 'collections.abc' - later python versions changed where this was imported from
- upgrade to python 3.10 - update many packages for python 3.10 compatibility - rip apart setup.py for uber and ubersystem. I for SURE broke stuff here. - change pavement.py to explicitly install plugin dependencies - remove NPM install stuff from Dockerfile - implement multi-stage dockerfile support for dev vs prod (to mount your own code in the container for easier dev support) - this doesn't quite get a running app, but, it gets as far as cherrypy starting - DO NOT USE THIS without a TON more testing - does allow debugging in PyCharm :)
- assumes you have plugins/uber and other plugins populated - this is a good base to build on to work up to kubernetes support
Contributor
Author
|
goes with magfest/ubersystem#3949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sup, long time no mag code. Not sure exactly why today, but felt like seeing if I could get ubersystem running in docker.
This is a PR that attempts to modernize the Dockerfile stuff in uber/sideboard, it's experimental but builds working containers that are running cherrypy and listening on the right port (there's some other stuff beyond that point which is unhappy).
this is standalone and doesn't require any salt/config stuff, the idea would likely be to have salt still create all the config settings but replace all the install steps for sideboard with a prebuilt docker image. Should probably make things easier.
This is all a quick experiment, and I'm stomping on a lot of backwards compatibility and dependency install stuff that will likely need more work. in particular, setup.py is shredded (might be a good thing? but definitely breaks stuff)
I probably won't have time to mess with this much more beyond today, but, if you were looking to reincarnate Docker builds, hopefully this could be a decent starting point.
Plus, bonus, PyCharm these days has excellent support for debugging inside docker containers, and that's already working with just these changes.
I broke npm support temporarily, that needs to get added back in. Easier ways probably exist these days with docker multi-stage builds and "COPY FROM" commands in the Dockerfile.