Parse 'approach NACK' as AckType::ApproachNack#71
Merged
maflcko merged 1 commit intomaflcko:mainfrom Jan 5, 2026
Merged
Conversation
Collaborator
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
The summary comment parser treated "Concept ACK, but approach NACK." as a `Concept NACK` because it only matched "Approach NACK" with the exact capitalization. Make the "Approach/Concept N?ACK" pattern capitalization-insensitive and add regression tests. Ref: bitcoin/bitcoin#34165 (review)
l0rinc
force-pushed
the
l0rinc/summary-approach-nack-case-insensitive
branch
from
d3a7723 to
15c56be
Compare
Owner
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bitcoin/bitcoin#34165 (review), the text
Concept ACK, but approach NACKwas summarized asConcept NACKbyDrahtBotbecause it only matchedApproach NACKwith the exact capitalization.Make the
[Aa]pproach/[Cc]onceptprefix capitalization-insensitive and add a regression test.