feat(account): login with username or email#1869
Open
huzaifaedhi22 wants to merge 22 commits intomainfrom
Open
feat(account): login with username or email#1869huzaifaedhi22 wants to merge 22 commits intomainfrom
huzaifaedhi22 wants to merge 22 commits intomainfrom
Conversation
dargmuesli
reviewed
Apr 10, 2025
Member
dargmuesli
left a comment
dargmuesli
left a comment
There was a problem hiding this comment.
195 files changed look odd, should this PR target beta?
Contributor
Author
|
Yes this will target beta as we have account restyle changes there. |
dargmuesli
requested changes
Apr 10, 2025
Member
|
@huzaifaedhi22 what's the status on this? |
* feat(tailwind): add accent colors * feat(button-colored): update secondary style * feat(form-account-sign-in): update registration button * feat(tailwind): add accent fancy * feat(AppLink): update accent color * feat: update ButtonColored component to accept more styles * feat(form): update form design to match new one * chore(i18n): update placeholder text to "Create an account" * feat(footer): create footer component * feat(layout): add footer component to default layout * fix(account): convert route paths to route names in footer component * chore(tests): update visual regression snapshots * chore(tests): add visual regression snapshots * chore(tests): add visual regression test * feat(account): add modals for privacy policy and general terms acceptance * feat(button): add confirm button component * chore(tailwind): add colors to tailwind config * feat(account-register): add privacy policy and general terms modal to signup flow * fix: linting errors * fix(modal): resolve transition issue between modals * feat(account):add uuid field to accountRegistration mutation response * feat(account): add acceptLegalTermAcceptance mutation * feat(account): include legal acceptance mutation in registration flow * chore(gql): update generated gql files * feat(account): add terms id to registration flow * feat(generalTerms): create and use general terms query * Merge branch 'master' into feat/account/restyle * fix(lint): typos in graph ql files * fix(typo) : remove typo * refactor(query): use nodes instead of edges * chore(shad-cn): add shad cn dialogue and shadbutton * chore(colors): add colors from new design * feat(account): implement updated design for account signup and login * refactor(empty-lines):remove * chore(shad-cn): shadcn components index and deps * feat(modals): use shadcn for modals * chore(text): update text * feat(forms): use updated design for forms * feat(styling): update modals for dark mode * feat(validator): add validator to allow both username and email to sign in * chore(colors): add colors * fix(deps): sync lockfile * fix(shadcn): use updated import * fix(shad-button): export as ShadButton to avoid conflict * fix(css): merge app.css and maevsi.css * chore(deps): deduplicate dependencies * fix(turnstile): set token without store * chore(tests) : update tests * fix(styles): pass correct color variable * feat(modals): add back button to modals * fix(termId): add legal term id to account registration mutation * feat(pending-verify): add pending verification email page * chore(gql): update gql files * refactor(verify): create verify directory instead * chore(tests): update tests * chore(tests): add new screenshots * chore(tests): update tests * chore(test): update snapshots * chore(deps): mark compatibility with sqitch v7 * chore: fix back icon * chore: revert readdition of style utility * chore: restyle forms * feat(components): upgrade dialog component * chore(graphql): update schema * refactor(graphql): extract legal term fragment * chore(graphql): reduce returned values for legal term acceptance * fix(account): revert sign in form input to email * refactor(utils): sort validation functions * refactor(components): replace legacy footer * refactor(components): extract footer button * feat(form): align sign in and registration * feat(session): add welcome screen * feat(components): add button size * feat(components): add top bar * feat(form): remove placeholders * chore: work in layout updates * chore(deps): upgrade shadcn-nuxt styles * refactor(legal): extract content component * feat(legal): update report form link * refactor(app): reorder components * fix(app): correct backdrop height * chore(app): remove nuxt layout comment * fix(components): correct icon labels * chore: rework models to stepper * fix(components): correct button variant * fix(components): use `span` for typography * feat(pages): extract legal term page * chore(sqitch): update to v7.0.0-beta.10 * chore: clean up --------- Co-authored-by: huzaifaedhi2 <huzaifaejaz09@gmail.com>
huzaifaedhi22
force-pushed
the
feat/account/emailOrUsername
branch
from
a921031 to
d729ff5
Compare
dargmuesli
force-pushed
the
feat/account/emailOrUsername
branch
from
bdac338 to
dd9e044
Compare
dargmuesli
reviewed
May 13, 2025
Member
dargmuesli
left a comment
dargmuesli
left a comment
There was a problem hiding this comment.
Please make sure the PRs' diffs look as they should when requesting review
tests/e2e/specs/server/sitemap.spec.ts-snapshots/sitemap-content-de-Mobile-Chrome-linux.xml
Show resolved
Hide resolved
dargmuesli
requested changes
Jun 2, 2025
Member
dargmuesli
left a comment
dargmuesli
left a comment
There was a problem hiding this comment.
See comments from last review above.
dargmuesli
requested changes
Jun 5, 2025
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
📝 Checklist