mariadb/mysql doesn't like " around table names#2
Open
kjbrandstatter wants to merge 2 commits intomaettu:masterfrom
Open
mariadb/mysql doesn't like " around table names#2kjbrandstatter wants to merge 2 commits intomaettu:masterfrom
kjbrandstatter wants to merge 2 commits intomaettu:masterfrom
Conversation
added 2 commits
May 3, 2024 18:11
Also schema fails to create because key is a reserved keyword
escaped/quoted properly
Owner
|
@kjbrandstatter thanks for the patch! Please gloss over #1 If you both can sort this out, bilaterally, that will be perfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also schema fails to create because key is a reserved keyword
And "BEGIN" is sufficient for mysql, "begin transaction" throws errors.
Tested this change against postgres as well to make sure it was ok without quotes but am open to suggestions.
The column i left configurable cause changing it would obviously break existing setups.
example of error seen in mysql/mariadb prior
DBDish::mysql: Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"junk" ( keyname TEXT UNIQUE NOT NULL, value INTEGER NO...' at line 1 (1064)