Refactor MT.1076 to fix reported results #1430
Open
+122
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d error handling - Improve checks for require scopes and authentication context. - Proceed with obfuscated report if attempts to de-obfuscate fail. - More resilient cleanup of temp file in end block. - Improved verbose output in error handling. - Standardize variable naming. - Add timestamp to file output to avoid conflicts and clarify leftover history. - Fix condition where results were returned as an array instead of boolean.
SamErde
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Test-MtExoMoeraMailActivity to fix the MT.1076 result status bug, improve handling of Graph report obfuscation, and make the temp-file usage more robust, while also updating the spelling dictionary for new terminology.
Changes:
- Rewrote
Test-MtExoMoeraMailActivityto use a clear begin/process/end structure, fix the boolean return logic, and improve handling of obfuscated Graph reports (including proceeding when de-obfuscation is not possible). - Centralized temp CSV file handling with timestamped filenames and end-block cleanup, and improved verbose/error messaging around report retrieval and CSV import failures.
- Added “Delicensing” and “MOERA” to
.cspell.jsonto prevent false-positive spelling warnings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| powershell/public/maester/exchange/Test-MtExoMoeraMailActivity.ps1 | Refactors MT.1076’s implementation to correct the pass/fail boolean, handle Graph report obfuscation and CSV import more robustly, and standardize verbose and cleanup behavior. |
| .cspell.json | Extends the custom dictionary with new domain-specific terms used by the updated Exchange tests and docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e for obfuscation tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored
powershell/public/maester/exchange/Test-MtExoMoeraMailActivity.ps1to fix #1429, which current returns afailstatus when checks actually pass.Contribution Checklist
Before submitting this PR, please confirm you have completed the following:
/powershell/tests/pester.ps1on your local system.