Skip to content

Comments

Fix(NetworkExtension): Make [NWHostEndpoint hostname] return-nullable#779

Merged
madsmtm merged 1 commit intomadsmtm:mainfrom
PaulDance:fix-netext-nwhostendpoint-hostname-gen
Feb 15, 2026
Merged

Fix(NetworkExtension): Make [NWHostEndpoint hostname] return-nullable#779
madsmtm merged 1 commit intomadsmtm:mainfrom
PaulDance:fix-netext-nwhostendpoint-hostname-gen

Conversation

@PaulDance
Copy link
Contributor

Fixes #778.

@PaulDance PaulDance marked this pull request as ready for review September 3, 2025 18:27
@madsmtm madsmtm added bug Something isn't working A-framework Affects the framework crates and the translator for them labels Sep 3, 2025
@PaulDance PaulDance force-pushed the fix-netext-nwhostendpoint-hostname-gen branch from 82fcae5 to 9bfa90e Compare September 3, 2025 18:54
@madsmtm
Copy link
Owner

madsmtm commented Sep 3, 2025

Thanks!

I won't merge this 'till after I begin on v0.4, so don't worry about keeping it rebased.

@PaulDance
Copy link
Contributor Author

Thanks!

NP 🙂

I won't merge this 'till after I begin on v0.4

👌

so don't worry about keeping it rebased

Yeah, I saw some conflicts, so acted out of habit, but alright, I'll let you handle this, then!

Fixes madsmtm#778.

Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@madsmtm madsmtm force-pushed the fix-netext-nwhostendpoint-hostname-gen branch from 9bfa90e to fce665c Compare February 15, 2026 17:20
@madsmtm madsmtm merged commit 340e878 into madsmtm:main Feb 15, 2026
18 checks passed
@madsmtm
Copy link
Owner

madsmtm commented Feb 15, 2026

I've begun v0.4 work now, so I've rebased and merged this now, thanks!

@PaulDance
Copy link
Contributor Author

Cool, thanks!

@PaulDance PaulDance deleted the fix-netext-nwhostendpoint-hostname-gen branch February 15, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-framework Affects the framework crates and the translator for them bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-[NWHostEndpoint hostname] can panic on "unexpected NULL returned from -[NWAddressEndpoint hostname]"

2 participants