Skip to content

fix memory leak #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinshiyi11 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix memory leak #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions android/src/main/java/dk/madslee/imageSequence/RCTImageSequenceView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@
import android.graphics.BitmapFactory;
import android.graphics.drawable.AnimationDrawable;
import android.graphics.drawable.BitmapDrawable;
import android.graphics.drawable.Drawable;
import android.util.Log;
import android.os.AsyncTask;
import android.widget.ImageView;

import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.net.URI;
import java.net.URL;
import java.util.ArrayList;
import java.util.HashMap;
Expand Down Expand Up @@ -43,11 +46,19 @@ public DownloadImageTask(Integer index, String uri, Context context) {

@Override
protected Bitmap doInBackground(String... params) {
if (this.uri.startsWith("http")) {
return this.loadBitmapByExternalURL(this.uri);
}
try {
if (this.uri.startsWith("http")) {
return this.loadBitmapByExternalURL(this.uri);
} else if (this.uri.startsWith("file://")) {
File file = new File(new URI(this.uri));
return BitmapFactory.decodeFile(file.getAbsolutePath());
}

return this.loadBitmapByLocalResource(this.uri);
} catch (Exception e) {

return this.loadBitmapByLocalResource(this.uri);
}
return null;
}


Expand All @@ -57,20 +68,28 @@ private Bitmap loadBitmapByLocalResource(String uri) {

private Bitmap loadBitmapByExternalURL(String uri) {
Bitmap bitmap = null;
InputStream in = null;

try {
InputStream in = new URL(uri).openStream();
in = new URL(uri).openStream();
bitmap = BitmapFactory.decodeStream(in);
} catch (IOException e) {
} catch (Exception e) {
e.printStackTrace();
} finally {
try {
if (in != null) {
in.close();
}
} catch (Exception e) {
}
}

return bitmap;
}

@Override
protected void onPostExecute(Bitmap bitmap) {
if (!isCancelled()) {
if (!isCancelled() && bitmap != null) {
onTaskCompleted(this, index, bitmap);
}
}
Expand All @@ -91,6 +110,11 @@ private void onTaskCompleted(DownloadImageTask downloadImageTask, Integer index,
}

public void setImages(ArrayList<String> uris) {
Drawable drawable = getDrawable();
if(drawable instanceof AnimationDrawable){
((AnimationDrawable)drawable).stop();
}

if (isLoading()) {
// cancel ongoing tasks (if still loading previous images)
for (int index = 0; index < activeTasks.size(); index++) {
Expand All @@ -108,7 +132,7 @@ public void setImages(ArrayList<String> uris) {
try {
task.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
} catch (RejectedExecutionException e){
Log.e("react-native-image-sequence", "DownloadImageTask failed" + e.getMessage());
Log.e("image-sequence", "DownloadImageTask failed" + e.getMessage());
break;
}
}
Expand Down